Get tests passing and recognize foreign content nodes better #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepping for a release. One test was not passing: HtmlBuilderTest.testRelLinksWhenRelisPartOfData I was also getting IDE warnings that there were some uses of `@since 10` APIs which made it hard to run tests outside mvn. This commit cleans up those issues and a few warnings about `@deprecated` in javadoc without a corresponding annotation. Signed-off-by: Mike Samuel <mikesamuel@gmail.com>
|
Some of these fixes are also on my PRs... Would be nice of you could comment on issue #301 |
|
FOr a new release you should also consider PR #313 |
|
@mikesamuel : May I know when we are planning to have a new release, changes from some of our PRs are needed for us |
|
@mikesamuel can we get a release please with new fixes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepping for a release.
One test was not passing:
HtmlBuilderTest.testRelLinksWhenRelisPartOfData
I was also getting IDE warnings that there were some uses of
@since 10APIs which made it hard to run tests outside mvn.This commit cleans up those issues and a few warnings about
@deprecatedin javadoc without a corresponding annotation.